new: nightbase mig
This commit is contained in:
16
2025-11-13-nightbase-migration/REVIEW.md
Normal file
16
2025-11-13-nightbase-migration/REVIEW.md
Normal file
@@ -0,0 +1,16 @@
|
||||
# Review
|
||||
|
||||
## 0001-temp-backup.sh
|
||||
- **CRITICAL**: No validation that tmpfs mount succeeded before rsync
|
||||
- **CRITICAL**: No check that source path exists
|
||||
- **CRITICAL**: No check for sufficient available RAM (64GB required)
|
||||
|
||||
## 0002-partition.sh
|
||||
- **CRITICAL**: Will destroy all data on `/dev/nvme1n1` without confirmation
|
||||
- **CRITICAL**: Variable `$PART_DEV` may fail if lsblk output format differs; needs `/dev/` prefix for mkfs.btrfs
|
||||
- **WARNING**: No validation that device exists before gdisk
|
||||
|
||||
## 0003-temp-restore.sh
|
||||
- **CRITICAL**: No check that source path exists
|
||||
- **CRITICAL**: No validation that destination is mounted/writable
|
||||
- **WARNING**: Will overwrite existing data at destination without confirmation
|
||||
Reference in New Issue
Block a user