diff --git a/.gitea/workflows/build.yaml b/.gitea/workflows/build.yaml index 71a1ce5..1af71b4 100644 --- a/.gitea/workflows/build.yaml +++ b/.gitea/workflows/build.yaml @@ -11,7 +11,7 @@ jobs: - name: Rust uses: actions-rust-lang/setup-rust-toolchain@v1 with: - targets: x86_64-unknown-uefi + target: x86_64-unknown-uefi - name: Build run: cargo build --release - name: Release diff --git a/src/codec/image.rs b/src/codec/image.rs index 3acbd1d..a1a4ec1 100644 --- a/src/codec/image.rs +++ b/src/codec/image.rs @@ -1,4 +1,4 @@ -use alloc::{boxed::Box, vec::Vec}; +use alloc::vec::Vec; use crate::{color::Color, error::RenderError}; @@ -14,7 +14,7 @@ pub struct ImageData { impl ImageData { pub fn transform(&self, transformer: &dyn Transformer) -> Self { - transformer.transform(&self) + transformer.transform(self) } } diff --git a/src/codec/image/png.rs b/src/codec/image/png.rs index 90ea514..60a54b9 100644 --- a/src/codec/image/png.rs +++ b/src/codec/image/png.rs @@ -10,11 +10,11 @@ pub struct PngDecoder; impl ImageDecoder for PngDecoder { fn decode(&self, bytes: &[u8]) -> Result { let (header, rgba_pixels) = - png_decoder::decode(bytes).map_err(|err| RenderError::from(err))?; + png_decoder::decode(bytes).map_err(RenderError::from)?; let pixels = rgba_pixels .chunks(4) - .map(|chunk| Color::new(chunk[0].into(), chunk[1].into(), chunk[2].into())) + .map(|chunk| Color::new(chunk[0], chunk[1], chunk[2])) .collect(); Ok(ImageData { diff --git a/src/codec/transform/crop.rs b/src/codec/transform/crop.rs index 660b733..a4442e1 100644 --- a/src/codec/transform/crop.rs +++ b/src/codec/transform/crop.rs @@ -1,4 +1,3 @@ -use alloc::vec; use crate::{codec::image::ImageData, color::Color}; diff --git a/src/codec/video.rs b/src/codec/video.rs index e6423e1..16a906d 100644 --- a/src/codec/video.rs +++ b/src/codec/video.rs @@ -1,6 +1,6 @@ use alloc::vec::Vec; -use crate::{color::Color, error::RenderError, util::time::Milliseconds}; +use crate::{error::RenderError, util::time::Milliseconds}; use super::{image::ImageData, transform::Transformer}; diff --git a/src/codec/video/gif.rs b/src/codec/video/gif.rs index 5cae64c..c9eb9bf 100644 --- a/src/codec/video/gif.rs +++ b/src/codec/video/gif.rs @@ -2,7 +2,7 @@ use alloc::{format, vec::Vec}; use embedded_graphics_core::{ image::ImageDrawable, pixelcolor::Rgb888, - prelude::{Dimensions, DrawTarget, PixelColor, Point, RgbColor, Size}, + prelude::{Dimensions, DrawTarget, Point, RgbColor, Size}, primitives::Rectangle, }; use tinygif::ParseError; @@ -15,7 +15,7 @@ pub struct GifDecoder; impl VideoDecoder for GifDecoder { fn decode(&self, bytes: &[u8]) -> Result { - let image = tinygif::Gif::from_slice(bytes).map_err(|e| RenderError::from(e))?; + let image = tinygif::Gif::from_slice(bytes).map_err(RenderError::from)?; let frames = image .frames() diff --git a/src/graphic/buffer.rs b/src/graphic/buffer.rs index 5add4eb..296e5ac 100644 --- a/src/graphic/buffer.rs +++ b/src/graphic/buffer.rs @@ -38,7 +38,7 @@ impl Buffer { gop.blt(BltOp::BufferToVideo { buffer: &self.pixels, src: BltRegion::SubRectangle { - coords: coords, + coords, px_stride: self.width, }, dest: coords, @@ -52,7 +52,7 @@ impl From for Buffer { Buffer { width: value.width, height: value.height, - pixels: value.pixels.iter().map(|p| BltPixel::from(p)).collect(), + pixels: value.pixels.iter().map(BltPixel::from).collect(), } } }