# PR Checklist
- [ ] Have you checked if it works normally in all models? *Ignore this
if it doesn't use models.*
- [x] Have you checked if it works normally in all web, local, and node
hosted versions? If it doesn't, have you blocked it in those versions?
- [x] Have you added type definitions?
# Description
When an user is not logged in and anytime any dialog is about to open,
undefined property access of `message` event happens, opening error
dialog, which causes another undefined property access, and so forth.
This does not stop so it blocks even log in itself.
This PR mitigates it by simply converting those accesses to optional
chaining.
# PR Checklist
- [ ] Have you checked if it works normally in all models? *Ignore this
if it doesn't use models.*
- [x] Have you checked if it works normally in all web, local, and node
hosted versions? If it doesn't, have you blocked it in those versions?
- [x] Have you added type definitions?
# Description
When dividers within a group becomes many, it would throw.
Found out that the divider was referencing the whole list of toggles
(root level), not `items` (items of a group it belongs), as divider
development happened before the group. It caused out of index array
access and `prevToggle.type` would throw because `prevToggle` can be
`undefined`.
# PR Checklist
- [ ] Have you checked if it works normally in all models? *Ignore this
if it doesn't use models.*
- [x] Have you checked if it works normally in all web, local, and node
hosted versions? If it doesn't, have you blocked it in those versions?
- [x] Have you added type definitions?
# Description
I can't find the history but `onclick` is always `undefined`, never
assigned. But it's being called in an `onclick`. This blocks all types
of exports. I just removed it.
# PR Checklist
- [ ] Have you checked if it works normally in all models? *Ignore this
if it doesn't use models.*
- [x] Have you checked if it works normally in all web, local, and node
hosted versions? If it doesn't, have you blocked it in those versions?
- [x] Have you added type definitions?
# Description
Getting one single chat at a specified index would help lighten Lua
scripts in certain scenarios such as "get the second last chat".
Currently I have to iterate (in `getFullChatMain`) the whole chat by
`getFullChat(id)` and then `fullChat[#fullChat - 1]`. With this PR, it
is simplified as `getChat(id, -2)`
Returns `nil` when no chat exists in the index.
# PR Checklist
- [ ] Have you checked if it works normally in all models? *Ignore this
if it doesn't use models.*
- [ ] Have you checked if it works normally in all web, local, and node
hosted versions? If it doesn't, have you blocked it in those versions?
- [ ] Have you added type definitions?
# Description
Standardize variable name display color to yellow
# PR Checklist
- [ ] Have you checked if it works normally in all models? *Ignore this
if it doesn't use models.*
- [ ] Have you checked if it works normally in all web, local, and node
hosted versions? If it doesn't, have you blocked it in those versions?
- [ ] Have you added type definitions?
# Description
Add null check for scroll element to prevent runtime errors
Sorry for not catching this earlier - added proper validation to prevent
crashes.
# PR Checklist
- [ ] Have you checked if it works normally in all models? *Ignore this
if it doesn't use models.*
- [ ] Have you checked if it works normally in all web, local, and node
hosted versions? If it doesn't, have you blocked it in those versions?
- [ ] Have you added type definitions?
# Description
Implements scroll position preservation functionality for RisuAI's
Trigger V2 menuMode 0. When users navigate away from menuMode 0 and then
return, the scroll position is now automatically restored to where they
left off.
Changes:
- Saves scroll position when leaving menuMode 0
- Restores saved scroll position when returning to menuMode 0
- Improves user experience by maintaining navigation context"
This enhancement provides a smoother user experience by eliminating the
need to manually scroll back to previous positions after navigation.
# PR Checklist
- [ ] Have you checked if it works normally in all models? *Ignore this
if it doesn't use models.*
- [ ] Have you checked if it works normally in all web, local, and node
hosted versions? If it doesn't, have you blocked it in those versions?
- [ ] Have you added type definitions?
# Description
This PR adds a back button functionality and improves textarea
components in Trigger V2.
## Changes Made
- Added back button for better navigation
- Updated textarea components for improved user experience
- Enhanced UI/UX in Trigger V2 section
This is my first pull request to this project. I would greatly
appreciate thorough review and feedback from maintainers. Please let me
know if any changes or improvements are needed.
Thank you for your time and consideration!
# PR Checklist
- [ ] Have you checked if it works normally in all models? *Ignore this
if it doesn't use models.*
- [x] Have you checked if it works normally in all web, local, and node
hosted versions? If it doesn't, have you blocked it in those versions?
- [x] Have you added type definitions?
# Description
For Lua scripts triggered by button clicks, `lowLevelAccess` flag is not
respecting module level settings, only character's.
This PR allows modules with low level access set run low level functions
in `onButtonClick`.
# PR Checklist
- [ ] Have you checked if it works normally in all models? *Ignore this
if it doesn't use models.*
- [ ] Have you checked if it works normally in all web, local, and node
hosted versions? If it doesn't, have you blocked it in those versions?
- [ ] Have you added type definitions?
# Description
In my previous PR #822 there's an issue where the module lore sort was
not saving properly. I believe this PR will fix that. I appreciate your
time.
# PR Checklist
- [ ] Have you checked if it works normally in all models? *Ignore this
if it doesn't use models.*
- [x] Have you checked if it works normally in all web, local, and node
hosted versions? If it doesn't, have you blocked it in those versions?
- [ ] Have you added type definitions?
# Description
While tracking down the error "The first argument must be one of type
string, Buffer, ArrayBuffer, Array, or Array-like Object. Received type
undefined" that occurs during ComfyUI image generation, I found an issue
in the `fetchNative` function.
## Issue
When sending GET or DELETE requests, the `realBody` variable is set to
`undefined`, but it's directly passed to `Buffer.from()` without null
checking, causing the error.
## Fix
Added a simple null check to prevent the error:
```typescript
// Before
body: Buffer.from(realBody).toString('base64'),
// After
body: realBody ? Buffer.from(realBody).toString('base64') : '',
# PR Checklist
- [ ] Have you checked if it works normally in all models? *Ignore this
if it doesn't use models.*
- [ ] Have you checked if it works normally in all web, local, and node
hosted versions? If it doesn't, have you blocked it in those versions?
- [ ] Have you added type definitions?
# Preview
# Description
This PR introduces following:
- Add memory selection metrics to HypaV3
# PR Checklist
- [ ] Have you checked if it works normally in all models? *Ignore this
if it doesn't use models.*
- [x] Have you checked if it works normally in all web, local, and node
hosted versions? If it doesn't, have you blocked it in those versions?
- [x] Have you added type definitions?
# Description
## Related PRs
- This PR replaces the previous implementation in
[#848](https://github.com/kwaroran/RisuAI/pull/848).
---
## Problem
- After [#848](https://github.com/kwaroran/RisuAI/pull/848), input token
counts and `\n\n` spacing changed (e.g. custom API & OpenAI compatible
models).
- Before, I used the `memo` field in each message to help get **the
final, parsed and pre-processed prompt template** from the `formated`
array for storage.
- But the `memo` field is used in `pushPrompts()` to decide when to
merge strings inside `formated`:
```js
// Existing code
if (chat.role === 'system') {
const endf = formated.at(-1)
if (endf && endf.role === 'system' && endf.memo === chat.memo && endf.name === chat.name) {
formated[formated.length - 1].content += '\n\n' + chat.content
}
}
```
- Therefore, relying on `memo` produced wrong results.
## Solution
- Rolled back all `memo` logic (For a clean diff, compare with 040652d,
the last version before the memo logic was added).
- Added `pushPromptInfoBody()` (independent of global `formated`):
```js
function pushPromptInfoBody(role, fmt, promptBody) {
if (!fmt.trim()) return;
promptBody.push({
role: role,
content: risuChatParser(fmt),
});
}
```
- Prompt text is now collected in a single switch(`card.type`) block,
without needing to filter with `memo` or external fields.
## Result
Prompt text is still stored per message without side effects.
## Considerations (commit
[8dc05cc](8dc05ccace))
- Extracting only the original `globalNote` is hard unless parser order
is changed.
1. When `positionParser` is called first, sections marked as `position`
are inserted early, making it impossible to extract only the prompt
template afterward.
2. If `risuChatParser` is called separately **just to save the prompt
text**, the saved prompt may differ from the actual prompt sent,
especially in cases involving `{{random}}` values.
- Reordering the function calls might help, but since it could change
the prompt that is actually sent and cause differences from the previous
output, it may be better to leave things as they are.
- Personally, I tend to avoid using `position` in main system prompts;
adding it often makes the main prompt structure a bit messy (Using
`position` is very useful for things that change frequently, such as
bots or personas)
- Global notes are typically used for individual bots, rather than as
prompts shared globally, so skipping them here has no functional
drawback, I think.
- The **Custom Inner Format** fields such as authorNote, persona,
description, and memory mainly serve as labels, so things like
`{{random}}` are rarely used here. For this reason, I used **2(only
`risuChatParser` is called just to save the prompt text)** in this
context.
## Final Note
Sorry for any inconvenience! If you have questions or feedback, please
let me know.
# PR Checklist
- [ ] Have you checked if it works normally in all models? *Ignore this
if it doesn't use models.*
- [ ] Have you checked if it works normally in all web, local, and node
hosted versions? If it doesn't, have you blocked it in those versions?
- [ ] Have you added type definitions?
# Description
While testing image generation with ComfyUI, I encountered a permission
error when trying to send requests to the local ComfyUI server. The
application was throwing the following error:
`url not allowed on the configured scope: http://localhost:8188/prompt`
## Solution
Added a wildcard URL pattern to `migrated.json` that explicitly allows
connections to localhost with any port number:
```json
{
"url": "http://*:**"
}
# PR Checklist
- [ ] Have you checked if it works normally in all models? *Ignore this
if it doesn't use models.*
- [x] Have you checked if it works normally in all web, local, and node
hosted versions? If it doesn't, have you blocked it in those versions?
- [x] Have you added type definitions?
# Description
It fixes a bug identified during the testing of ComfyUI image generation
in Playground. Specifically, the error alert, which is supposed to
display error messages, was not appearing when a parameter was of an
error type. This fix ensures that error alerts are now correctly
displayed under such conditions.
# PR Checklist
- [ ] Have you checked if it works normally in all models? *Ignore this
if it doesn't use models.*
- [x] Have you checked if it works normally in all web, local, and node
hosted versions? If it doesn't, have you blocked it in those versions?
- [x] Have you added type definitions?
# Description
When a user uses short max context length and `reserve` is bigger than
the length, `loadLoreBooksMain` returns a `nil` but `loadLoreBooks`
tries to decode it as a JSON.
It will return a stringified empty array instead of a nil.
# PR Checklist
- [ ] Have you checked if it works normally in all models? *Ignore this
if it doesn't use models.*
- [ ] Have you checked if it works normally in all web, local, and node
hosted versions? If it doesn't, have you blocked it in those versions?
- [ ] Have you added type definitions?
# Description
This PR resolves an issue appeared in [Revert to old loading
temp](858d6c2ad2)
# PR Checklist
- [ ] Have you checked if it works normally in all models? *Ignore this
if it doesn't use models.*
- [x] Have you checked if it works normally in all web, local, and node
hosted versions? If it doesn't, have you blocked it in those versions?
- [x] Have you added type definitions?
# Description
This PR adds ~~two~~ one function: ~~`getDescription()` for character
description, and~~ (See #852)`getAuthorsNote()` for author's note.
It also removes `LuaSafeIds.has(id)` from most reader functions without
any side effects. Since `getFullChatMain()` has no such check already
and everything else should be lighter than `getFullChatMain()`, I think
it'll be fine.
# PR Checklist
- [ ] Have you checked if it works normally in all models? *Ignore this
if it doesn't use models.*
- [ ] Have you checked if it works normally in all web, local, and node
hosted versions? If it doesn't, have you blocked it in those versions?
- [ ] Have you added type definitions?
# Description
This PR introduces following:
- Make only markdown content scrollable while keeping OK button visible
The `getDescription(triggerId)` function, documented at:
https://kwaroran.github.io/docs/srp/lua/#getdescriptiontriggerid was
missing from the codebase and has now been added.
# PR Checklist
- [ ] Have you checked if it works normally in all models? *Ignore this
if it doesn't use models.*
- [ o] Have you checked if it works normally in all web, local, and node
hosted versions? If it doesn't, have you blocked it in those versions?
- [ ] Have you added type definitions?
# Description
