mincomk/sysadmin-sessions
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
d408c8fcc98ffc772f12ceb516d0bebb6e85d761
sysadmin-sessions/2025-11-13-nightbase-migration/REVIEW.md
minco 2f3d199fab new: nightbase mig
2025-11-14 00:19:46 +09:00

717 B
Raw Blame History

Review

0001-temp-backup.sh

  • CRITICAL: No validation that tmpfs mount succeeded before rsync
  • CRITICAL: No check that source path exists
  • CRITICAL: No check for sufficient available RAM (64GB required)

0002-partition.sh

  • CRITICAL: Will destroy all data on /dev/nvme1n1 without confirmation
  • CRITICAL: Variable $PART_DEV may fail if lsblk output format differs; needs /dev/ prefix for mkfs.btrfs
  • WARNING: No validation that device exists before gdisk

0003-temp-restore.sh

  • CRITICAL: No check that source path exists
  • CRITICAL: No validation that destination is mounted/writable
  • WARNING: Will overwrite existing data at destination without confirmation